Files
TGSS/internal/server/ratelimiter.go
T
mahdiumandQwen-Coder 5a37903a72 fix: rate limiter ticker leak and context cancellation bug
- Stop ticker and signal goroutine exit in RegisterCleanup OnStop hook
- Call cancel() explicitly after AuthStatus instead of defer to prevent premature context cancellation
- Use consistent logger parameter in OnStop hook

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2026-03-11 16:18:18 +03:30

106 lines
2.1 KiB
Go

package server
import (
"context"
"sync"
"time"
"github.com/gin-gonic/gin"
"go.uber.org/fx"
"go.uber.org/zap"
"golang.org/x/time/rate"
)
type ClientLimiter struct {
limiter *rate.Limiter
lastSeen time.Time
}
type RateLimiter struct {
logger *zap.Logger
clients map[string]*ClientLimiter
mu sync.Mutex
}
func NewRateLimiter(logger *zap.Logger) *RateLimiter {
return &RateLimiter{logger: logger, mu: sync.Mutex{}, clients: map[string]*ClientLimiter{}}
}
func (r *RateLimiter) getLimiter(ip string) *rate.Limiter {
r.mu.Lock()
defer r.mu.Unlock()
if c, ok := r.clients[ip]; ok {
c.lastSeen = time.Now()
return c.limiter
}
limiter := rate.NewLimiter(rate.Every(time.Second*3), 5) // TODO: get from config
r.clients[ip] = &ClientLimiter{limiter: limiter, lastSeen: time.Now()}
return limiter
}
func (r *RateLimiter) CleanupRateLimiter() {
r.mu.Lock()
defer r.mu.Unlock()
for ip, clientLimiter := range r.clients {
if time.Since(clientLimiter.lastSeen) > time.Hour { // Delete ip ratelimiters older that 1 hour
delete(r.clients, ip)
}
}
}
func RegisterCleanup(lc fx.Lifecycle, logger *zap.Logger, r *RateLimiter) {
var ticker *time.Ticker
var stopChan chan struct{}
lc.Append(fx.Hook{
OnStart: func(ctx context.Context) error {
logger.Info("Starting rate limiter cleanup task", zap.Duration("interval", 30*time.Minute))
ticker = time.NewTicker(30 * time.Minute)
stopChan = make(chan struct{})
go func() {
for {
select {
case <-ticker.C:
logger.Info("Running rate limiter cleanup")
r.CleanupRateLimiter()
logger.Info("Rate limiter cleanup completed")
case <-stopChan:
return
}
}
}()
return nil
},
OnStop: func(ctx context.Context) error {
logger.Info("Stopping rate limiter cleanup task")
if ticker != nil {
ticker.Stop()
}
if stopChan != nil {
close(stopChan)
}
return nil
},
})
}
func (r *RateLimiter) RateLimit() gin.HandlerFunc {
return func(c *gin.Context) {
ip := c.ClientIP()
limiter := r.getLimiter(ip)
if !limiter.Allow() {
c.AbortWithStatusJSON(429, gin.H{"error": "Slow down pls"})
return
}
c.Next()
}
}